Skip to content

chore: make log output consistent#6314

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:fix-log
Jun 17, 2025
Merged

chore: make log output consistent#6314
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:fix-log

Conversation

@zirain
Copy link
Member

@zirain zirain commented Jun 15, 2025

before:

2025-06-15T12:45:17.988Z	INFO	provider.httpbin.sidecar	kubernetes/status_updater.go:109	status unchanged, bypassing update	{"runner": "provider"}
2025-06-15T12:45:17.989Z	INFO	provider	kubernetes/status_updater.go:145	received a status update	{"runner": "provider", "namespace": "default", "name": "connect"}
2025-06-15T12:45:17.989Z	INFO	provider.connect.default	kubernetes/status_updater.go:109	status unchanged, bypassing update	{"runner": "provider"}
2025-06-15T12:45:17.989Z	INFO	provider	kubernetes/status_updater.go:145	received a status update	{"runner": "provider", "namespace": "default", "name": "envoy-lua-filter"}
2025-06-15T12:45:17.989Z	INFO	xds-server	runner/runner.go:196	received an update	{"runner": "xds-server"}
2025-06-15T12:45:17.989Z	INFO	provider.envoy-lua-filter.default	kubernetes/status_updater.go:109	status unchanged, bypassing update	{"runner": "provider"}

after:

2025-06-15T13:00:20.921Z	INFO	provider	kubernetes/status_updater.go:143	received a status update	{"runner": "provider", "namespace": "default", "name": "eg", "kind": "Gateway"}
2025-06-15T13:00:20.921Z	INFO	provider	kubernetes/status_updater.go:108	status unchanged, bypassing update	{"runner": "provider", "name": "eg", "namespace": "default", "kind": "Gateway"}
2025-06-15T13:00:20.937Z	INFO	provider	kubernetes/status_updater.go:143	received a status update	{"runner": "provider", "namespace": "default", "name": "eg", "kind": "Gateway"}
2025-06-15T13:00:20.937Z	INFO	provider	kubernetes/status_updater.go:108	status unchanged, bypassing update	{"runner": "provider", "name": "eg", "namespace": "default", "kind": "Gateway"}
2025-06-15T13:00:20.966Z	INFO	provider	kubernetes/status_updater.go:143	received a status update	{"runner": "provider", "namespace": "default", "name": "eg", "kind": "Gateway"}
2025-06-15T13:00:20.967Z	INFO	provider	kubernetes/status_updater.go:108	status unchanged, bypassing update	{"runner": "provider", "name": "eg", "namespace": "default", "kind": "Gateway"}
2025-06-15T13:00:20.998Z	INFO	provider	kubernetes/status_updater.go:143	received a status update	{"runner": "provider", "namespace": "default", "name": "eg", "kind": "Gateway"}
2025-06-15T13:00:20.998Z	INFO	provider	kubernetes/status_updater.go:108	status unchanged, bypassing update	{"runner": "provider", "name": "eg", "namespace": "default", "kind": "Gateway"}

@zirain
chore: make log output consistent
bc15fcb 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner June 15, 2025 13:00
@zirain
update
d1dfb83 
Signed-off-by: zirain <zirain2009@gmail.com>
@codecov
Copy link

codecov bot commented Jun 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.64%. Comparing base (9219f82) to head (d1dfb83).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/status_updater.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6314      +/-   ##
==========================================
+ Coverage   70.56%   70.64%   +0.07%     
==========================================
  Files         220      220              
  Lines       36829    36827       -2     
==========================================
+ Hits        25989    26016      +27     
+ Misses       9302     9279      -23     
+ Partials     1538     1532       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arkodg arkodg requested review from a team June 16, 2025 17:49
@zirain zirain merged commit fc2f455 into envoyproxy:main Jun 17, 2025
45 of 47 checks passed
@zirain zirain deleted the fix-log branch June 17, 2025 01:39
@BrewTestBot BrewTestBot mentioned this pull request Aug 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zirain @zhaohuabing @arkodg